Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular/cli): re-introduce install package using shell spawn #16112

Merged
merged 1 commit into from Nov 8, 2019

Conversation

@clydin
Copy link
Member

clydin commented Nov 8, 2019

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the npm command.

@googlebot googlebot added the cla: yes label Nov 8, 2019
This works around a Windows CI failure that related to the PATH environment variable and a failure to located the `npm` command.
@clydin clydin force-pushed the clydin:workaround-win-ci-shell branch from 5bba44e to 1631c96 Nov 8, 2019
@clydin clydin marked this pull request as ready for review Nov 8, 2019
@alan-agius4

This comment has been minimized.

Copy link
Collaborator

alan-agius4 commented Nov 8, 2019

Should also fix #16115

@mgechev
mgechev approved these changes Nov 8, 2019
@mgechev mgechev merged commit b8257e2 into angular:master Nov 8, 2019
19 checks passed
19 checks passed
ci/angular: merge status All checks passed!
ci/angular: size No size change against base branch.
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-bazel Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ng-ve-snapshots Your tests passed on CircleCI!
Details
ci/circleci: e2e-cli-ve Your tests passed on CircleCI!
Details
ci/circleci: flake-jail Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: setup Your tests passed on CircleCI!
Details
ci/circleci: setup-and-build-win Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: test-browsers Your tests passed on CircleCI!
Details
ci/circleci: test-large Your tests passed on CircleCI!
Details
ci/circleci: test-large-ve Your tests passed on CircleCI!
Details
ci/circleci: test-win Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
cla/google All necessary CLAs are signed
mgechev added a commit that referenced this pull request Nov 8, 2019
…6112)

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the `npm` command.
@clydin clydin deleted the clydin:workaround-win-ci-shell branch Nov 8, 2019
@SenthilKumaranC

This comment has been minimized.

Copy link

SenthilKumaranC commented Nov 12, 2019

How to update angular cli with this patch?

npm install --save-dev @angular/cli@xxxxxxx

Edit : I have modified install-package.js and added shell : true , now ng add working!!!!!

clydin added a commit to clydin/angular-cli that referenced this pull request Nov 20, 2019
…gular#16112)

This works around a Windows CI failure that related to the PATH environment variable and a failure to located the `npm` command.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.