Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): add skipLibCheck to workspace tsconfig #16682

Merged
merged 5 commits into from Jan 16, 2020
Merged

fix(@schematics/angular): add skipLibCheck to workspace tsconfig #16682

merged 5 commits into from Jan 16, 2020

Conversation

alan-agius4
Copy link
Collaborator

Add skipLibCheck to speed up TypeScript analysis and prevent compilation errors caused by incompatible declaration files which were generated with older/new TS versions.

//cc @IgorMinar

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker labels Jan 16, 2020
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thanks

Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add this as a migration for 9?

@alan-agius4
Copy link
Collaborator Author

@filipesilva, @IgorMinar suggested to do the migration in v10

@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin January 16, 2020 17:12
Add skipLibCheck to speed up TypeScript analysis and prevent compilation errors caused by incompatible declaration files which were generated with older/new TS versions
…space tsconfig

Add skipLibCheck to speed up TypeScript analysis and prevent compilation errors caused by incompatible declaration files which were generated with older/new TS versions
@dgp1130 dgp1130 merged commit bcfccc9 into angular:master Jan 16, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 16, 2020

Merged to 9.0.x patch branch.

@alan-agius4 alan-agius4 deleted the skip-lib-check branch January 17, 2020 06:39
@dgp1130
Copy link
Collaborator

dgp1130 commented Jan 17, 2020

Managed to forget to check for multiple commits while merging to 9.0.x. Just remembered now and merged the others. They might be a little out-of-order on that branch.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants