Skip to content

fix(@angular/cli): added clarity on angular cli version issues #16892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix(@angular/cli): added clarity on angular cli version issues #16892

merged 1 commit into from
Feb 11, 2020

Conversation

johnpapa
Copy link
Contributor

@johnpapa johnpapa commented Feb 8, 2020

fixes #16888

@johnpapa
Copy link
Contributor Author

johnpapa commented Feb 8, 2020

@alan-agius4 new PR with proper commit title

alan-agius4
alan-agius4 approved these changes Feb 8, 2020
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks John, LGTM.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Feb 8, 2020
@dgp1130 dgp1130 merged commit 5f3ff00 into angular:master Feb 11, 2020
@dgp1130
Copy link
Collaborator

dgp1130 commented Feb 11, 2020

Also merged to 9.0.x patch branch.

@clydin clydin mentioned this pull request Feb 11, 2020
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

+1 more reviewer

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@johnpapa @dgp1130 @alan-agius4 @3imed-jaberi @googlebot