-
Notifications
You must be signed in to change notification settings - Fork 11.9k
feat(@schematics/angular): generate new projects with tslint 6.1.0 #17203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
A number of recommended rules have been removed in version 6, Should we add them in our https://github.com/palantir/tslint/pull/4871/files and https://github.com/palantir/tslint/pull/4312/files |
Discussed whether to preserve existing configs from previous version or accept new changes from TSLint. New projects should include the new version and have a custom config with all the old rules from the previous TSLint version. Existing projects in 9.x should have a migration allowing users to update to TSLint 6.1 if they choose to and include the old rules into their config. In v10 we would enable the migration for everyone, need to consider how this works with Prettier as well. This will prevent projects from backsliding on formatting. Once we get to ESLint migration, we can revisit how to best make that happen. |
tslint 6.1 adds support for TypeScript 3.8 syntax See: https://github.com/palantir/tslint/blob/master/CHANGELOG.md#v610
packages/schematics/angular/migrations/update-10/update-tslint.ts
Outdated
Show resolved
Hide resolved
packages/schematics/angular/migrations/update-10/update-tslint.ts
Outdated
Show resolved
Hide resolved
@alan-agius4 Thank you for considering my proposition! "variable-name": {
"options": ["ban-keywords", "check-format", "allow-pascal-case"],
}, |
In tslint version 6, several recommanded rules have been removed in the following PRs: palantir/tslint#4871 palantir/tslint#4312 With this change, we bring back these rules in the CLI.
In tslint version 6, several recommanded rules have been removed in the following PRs: palantir/tslint#4871 palantir/tslint#4312 With this migration we update the tslint depedency to 6+ and add back these rules in the user workspace `tslint.json` also we remove some deprecated rules. Until version 10, this is an opt-in migration and users will need to run this manually with the below command: ``` ng update @angular/cli --migrate-only tslint-version-6 ``` Closes: #17117 Reference: TOOL-1348
@clydin PTAL |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
tslint 6.1 adds support for TypeScript 3.8 syntax
See: https://github.com/palantir/tslint/blob/master/CHANGELOG.md#v610
Pr to update the package in the repo #17202
See individual commits for more details.