Skip to content

fix(@angular-devkit/build-angular): add defaults to reduce methods in… #17216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 13, 2020
Merged

fix(@angular-devkit/build-angular): add defaults to reduce methods in… #17216

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 9 additions & 10 deletions packages/angular_devkit/build_angular/src/angular-cli-files/utilities/bundle-calculator.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,17 +167,16 @@ abstract class Calculator {
} else {
// No differential builds, get the chunk size by summing its assets.
return chunk.files
.filter((file) => !file.endsWith('.map'))
.map((file: string) => {
.filter(file => !file.endsWith('.map'))
.map(file => {
const asset = this.assets.find((asset) => asset.name === file);
if (!asset) {
throw new Error(`Could not find asset for file: ${file}`);
}

return asset;
return asset.size;
})
.map((asset) => asset.size)
.reduce((l, r) => l + r);
.reduce((l, r) => l + r, 0);
}
}
}
Expand All @@ -197,8 +196,8 @@ class BundleCalculator extends Calculator {
const buildSizes = Object.values(DifferentialBuildType).map((buildType) => {
const size = this.chunks
.filter(chunk => chunk.names.indexOf(budgetName) !== -1)
.map((chunk) => this.calculateChunkSize(chunk, buildType))
.reduce((l, r) => l + r);
.map(chunk => this.calculateChunkSize(chunk, buildType))
.reduce((l, r) => l + r, 0);

return {size, label: `${this.budget.name}-${buildType}`};
});
Expand All @@ -223,8 +222,8 @@ class InitialCalculator extends Calculator {
label: `initial-${buildType}`,
size: this.chunks
.filter(chunk => chunk.initial)
.map((chunk) => this.calculateChunkSize(chunk, buildType))
.reduce((l, r) => l + r),
.map(chunk => this.calculateChunkSize(chunk, buildType))
.reduce((l, r) => l + r, 0),
};
});

Expand All @@ -244,7 +243,7 @@ class InitialCalculator extends Calculator {
class AllScriptCalculator extends Calculator {
calculate() {
const size = this.assets
.filter((asset) => asset.name.endsWith('.js'))
.filter(asset => asset.name.endsWith('.js'))
.map(asset => asset.size)
.reduce((total: number, size: number) => total + size, 0);

Expand Down