Skip to content

Conversation

alan-agius4
Copy link
Collaborator

Spread and Rest uses [[GetOwnProperty]]. Previously, properties with falsy values were being removed when using the spread operator due to an incorrect check.

https://tc39.es/proposal-object-rest-spread/#AbstractOperations-CopyDataProperties

Fixes #17021

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Apr 21, 2020
@alan-agius4 alan-agius4 requested a review from clydin April 21, 2020 07:56
…e with falsy values

Spread and Rest uses `[[GetOwnProperty]]`. Previously, properties with falsy values were being removed when using the spread operator due to an incorrect check.

https://tc39.es/proposal-object-rest-spread/#AbstractOperations-CopyDataProperties

Fixes #17021
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/core): workspace reader spreading/resting with falsy values fix(@angular-devkit/core): workspace reader spread/rest operator usage with falsy values Apr 21, 2020
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Apr 21, 2020
@neo
Copy link

neo commented Apr 21, 2020

Wow! Thank you @alan-agius4! 🎉

@kyliau kyliau merged commit 4e9fe35 into angular:master Apr 21, 2020
@alan-agius4 alan-agius4 deleted the workspace-reader-spread branch April 21, 2020 19:45
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why does prerendering create NamedChunks?
5 participants