Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented May 4, 2020

Locale data is now transformed to be compatible with the ECMAScript level of the application bundles. The locale data is also optimized to remove comments and unnecessary whitespace.

Fixes: #17497

@clydin clydin added the target: major This PR is targeted for the next major release label May 4, 2020
@clydin clydin force-pushed the locale-data-dl-opt branch from 9a84729 to 0b3dd1c Compare May 4, 2020 22:55
@petebacondarwin
Copy link
Contributor

Cool! So after this we could revert angular/angular@078b0be, right?

Locale data is now transformed to be compatible with the ECMAScript level of the application bundles.  The locale data is also optimized to remove comments and unnecessary whitespace.

Fixes: angular#17497
@clydin clydin force-pushed the locale-data-dl-opt branch from 0b3dd1c to d6095dd Compare May 5, 2020 13:00
@clydin
Copy link
Member Author

clydin commented May 5, 2020

Yes. The referenced changes can be reverted with this in place.
The locale data can also target the latest ECMAScript version now since this will downlevel to the appropriate level for both older browsers and browsers that support modules.

@clydin clydin requested a review from alan-agius4 May 5, 2020 13:03
Copy link
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you Charles!

I'll leave someone more competent to do the review and I'm happy to see that you sorted it out.

@petebacondarwin can you please help by rolling back the change from master?

This change also gives us an opportunity to in one of the next majors move the locale file into the most modern format and switch it over to esm format (eventually, not in v10).

@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label May 5, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

localization retains copyright in minimized main.js
6 participants