-
Notifications
You must be signed in to change notification settings - Fork 12k
fix(@angular-devkit/build-angular): update less library to version 3.11.3 #17898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this.
Kindly update the lock file and also re-write the commit message as per our commit guidelines, see: https://github.com/angular/angular-cli/blob/master/CONTRIBUTING.md#-commit-message-guidelines.
@alan-agius4 should I make new pull request? and I didnt find lock file for this project |
As you prefer, but you can push with force on this branch with a valid commit messages and the changes. The commit should be something like
The lock file is in the root of the repository. |
@alan-agius4 There are some errors for ci/circleci: test-large. Can you help me on solving this? |
@vishnutsivan, let me have a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. thanks.
@alan-agius4 one check is pending for long time Will it take more time? |
@vishnutsivan, don’t worry about that. The step is no available on the v9 branch. |
@alan-agius4 May I know why its not getting merged? |
Hi there, It will get merged later on by the caretaker when he is merging other PRs. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
less@3.11.1 has dependency with acorn@6.3.0 which has vulnerability issues