Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@angular-devkit/build-angular): dedupe modules #18009

Merged
merged 2 commits into from
Jun 29, 2020
Merged

fix(@angular-devkit/build-angular): dedupe modules #18009

merged 2 commits into from
Jun 29, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Jun 24, 2020

fix(@angular-devkit/build-angular): don't dedupe modules without a name and version

We should not try to dedupe secondary entrypoints, or modules which don't have a name and a version.

Closes #17967

fix(@angular-devkit/build-angular): don't dedupe linked modules

Closes #18021

@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Jun 24, 2020
@alan-agius4 alan-agius4 requested a review from clydin June 24, 2020 10:37
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Jun 24, 2020
…me or version

We should not try to dedupe secondary entrypoints, or modules which don't have a name and a version.

Closes #17967
@alan-agius4 alan-agius4 requested a review from clydin June 25, 2020 13:04
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): don't dedupe modules without a na… fix(@angular-devkit/build-angular): dedupe modules Jun 25, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ng build Module not found: Error: Recursion in resolving dedupe-duplicate-modules turn on/off option request
4 participants