Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove solutions tsconfig #18478

Merged
merged 4 commits into from
Aug 12, 2020
Merged

Remove solutions tsconfig #18478

merged 4 commits into from
Aug 12, 2020

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Aug 7, 2020

Following the issues highlighted in https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing and discussions held with the TypeScript team. Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

Closes #18040, closes #18130 and closes #18170

@alan-agius4 alan-agius4 added the target: major This PR is targeted for the next major release label Aug 7, 2020
…jects

Following the issues highlighted in https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing and discussions held with the TypeScript team. The best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced..

Closes #18040 and closes #18170
@alan-agius4 alan-agius4 marked this pull request as ready for review August 10, 2020 09:28
…onfig

Following the issues highlighted in https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing and discussions held with the TypeScript team. Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

Closes #18040, closes #18130 and closes #18170
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 10, 2020
AndrewKushnir pushed a commit to angular/angular that referenced this pull request Aug 11, 2020
Following the issues highlighted in
https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing
and discussions held with the TypeScript team.
Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

See: angular/angular-cli#18478

PR Close #38394
@filipesilva filipesilva merged commit 3db588f into angular:master Aug 12, 2020
@alan-agius4 alan-agius4 deleted the remove-solutions-tsconfig branch August 12, 2020 18:34
@LayZeeDK
Copy link

Isn't this considered a breaking change? In which version will this land?

@alan-agius4
Copy link
Collaborator Author

@LayZeeDK, why is this a breaking change? We’ll be running migrations to revert back the changes from existing projects.

It’s scheduled to land in 10.1

@LayZeeDK
Copy link

LayZeeDK commented Aug 12, 2020

  1. Do you consider introducing solution-style configs a breaking change?
  2. Do automated migrations negate breaking changes?

@alan-agius4
Copy link
Collaborator Author

alan-agius4 commented Aug 12, 2020

Do you consider introducing solution-style configs a breaking change?

No, solutions style tsconfig only effects the IDE’s. it’s not used by any compilation.

Do automated migrations negate breaking changes?

Certainly not.

@mhosman
Copy link

mhosman commented Aug 13, 2020

When you are gonna release this fix??

@alan-agius4
Copy link
Collaborator Author

This will be available in 10.1.0.

Today we’ll be releasing the pre-release version and you can try it out using ng update @angular/cli -—next

@LayZeeDK
Copy link

Do you consider introducing solution-style configs a breaking change?

No, solutions style tsconfig only effects the IDE’s. it’s not used by any compilation.

Fair point.

Do automated migrations negate breaking changes?

Certainly not.

Thanks, that's also my impression.

profanis pushed a commit to profanis/angular that referenced this pull request Sep 5, 2020
Following the issues highlighted in
https://docs.google.com/document/d/1eB6cGCG_2ircfS5GzpDC9dBgikeYYcMxghVH5sDESHw/edit?usp=sharing
and discussions held with the TypeScript team.
Together with the TypeScript team it was decided that the best course of action is to rollback this feature.

In future, it is not excluded that solution style tsconfigs are re-introduced.

See: angular/angular-cli#18478

PR Close angular#38394
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
6 participants