Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@ngtools/webpack): issue warning when using strictMetadataEmit #18479

Merged
merged 1 commit into from Aug 10, 2020
Merged

fix(@ngtools/webpack): issue warning when using strictMetadataEmit #18479

merged 1 commit into from Aug 10, 2020

Conversation

alan-agius4
Copy link
Collaborator

strictMetadataEmit option which is not intended to be used for applications. See: https://angular.io/guide/angular-compiler-options#strictmetadataemit

Closes #18424

@alan-agius4 alan-agius4 requested a review from clydin August 7, 2020 12:53
@alan-agius4 alan-agius4 added the target: patch This PR is targeted for the next patch release label Aug 7, 2020
`strictMetadataEmit` option which is not intended to be used  for applications. See: https://angular.io/guide/angular-compiler-options#strictmetadataemit

Closes #18424
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Aug 7, 2020
@filipesilva filipesilva merged commit 8763c64 into angular:master Aug 10, 2020
@alan-agius4 alan-agius4 deleted the strict-metadata-ngtools branch August 10, 2020 09:24
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"ng build" showing "ERROR in No NgModule metadata found for 'AppModule'" instead of detailed root errors
4 participants