Skip to content

Refactor remove unused code #18545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Refactor remove unused code #18545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6abe747
refactor(@schematics/angular): remove unused util and imports
alan-agius4 Aug 15, 2020
b1e92cc
refactor(@angular-devkit/core): remove unused imports
alan-agius4 Aug 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/angular_devkit/core/src/terminal/caps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
*/
import ReadableStream = NodeJS.ReadableStream;
import WriteStream = NodeJS.WriteStream;
import Socket = NodeJS.Socket;
const supportsColor = require('../../third_party/github.com/chalk/supports-color');

/**
Expand Down
3 changes: 1 addition & 2 deletions packages/ngtools/webpack/src/diagnostics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@
* found in the LICENSE file at https://angular.io/license
*/
import {
CompilerHost, Diagnostic, Diagnostics,
Diagnostic, Diagnostics,
Program, formatDiagnostics, isNgDiagnostic,
} from '@angular/compiler-cli';
import * as ts from 'typescript';
import { time, timeEnd } from './benchmark';
import { WebpackCompilerHost } from './compiler_host';

export enum DiagnosticMode {
Syntactic = 1 << 0,
Expand Down
1 change: 0 additions & 1 deletion packages/schematics/angular/interface/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
import { strings } from '@angular-devkit/core';
import {
Rule,
SchematicsException,
Tree,
apply,
applyTemplates,
Expand Down
9 changes: 0 additions & 9 deletions packages/schematics/angular/migrations/update-9/schematic-options_spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,15 +36,6 @@ describe('Migration to version 9', () => {
});

describe('schematic options', () => {
function getI18NConfig(localId: string): object {
return {
outputPath: `dist/my-project/${localId}/`,
i18nFile: `src/locale/messages.${localId}.xlf`,
i18nFormat: 'xlf',
i18nLocale: localId,
};
}

it('should replace styleext with style', async () => {
const workspace = JSON.parse(tree.readContent(workspacePath));
workspace.schematics = {
Expand Down