feat(@schematics/angular): add enableI18nLegacyMessageIdFormat defa…
#19232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ult to new projects The ViewEngine message extraction generates a variety of legacy formats for extracted message ids. These formats have a number of issues related to whitespace handling and reliance upon information inside the original HTML of a template. The new message format is more resilient to things like whitespace changes, and can be generated directly from calls to `$localize`, which allows messages in application code to have the same id as identical messages in templates. As a first step in migrating projects away from the legacy id format for i18n messages, this commit updates newly generated projects to turn off the legacy ids. In the future the default will be flipped and this can be removed. Eventually the legacy message id support will be removed altogether, probably in sync with removal of ViewEngine.
petebacondarwin
added
the
target: major
|
Related docs fix here angular/angular#39453 |
kyliau
approved these changes
Oct 27, 2020
petebacondarwin
added a commit
to petebacondarwin/angular
that referenced
this pull request
Oct 28, 2020
…r options guide The ViewEngine message extraction generated a variety of legacy formats for extracted message ids. These formats have a number of issues related to whitespace handling and reliance upon information inside the original HTML of a template. The new message format is more resilient, and can be generated directly from calls to `$localize`. This allows messages in application code to have the same id as identical messages in templates. As a first step in migrating projects away from the legacy id format for i18n messages, newly generated projects now turn off the legacy ids. See angular/angular-cli#19232. This commit updates the documentation to include information about this option, since it is now publicly exposed in new CLI projects.
alxhub
pushed a commit
to angular/angular
that referenced
this pull request
Oct 28, 2020
…r options guide (#39453) The ViewEngine message extraction generated a variety of legacy formats for extracted message ids. These formats have a number of issues related to whitespace handling and reliance upon information inside the original HTML of a template. The new message format is more resilient, and can be generated directly from calls to `$localize`. This allows messages in application code to have the same id as identical messages in templates. As a first step in migrating projects away from the legacy id format for i18n messages, newly generated projects now turn off the legacy ids. See angular/angular-cli#19232. This commit updates the documentation to include information about this option, since it is now publicly exposed in new CLI projects. PR Close #39453
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ult to new projects
The ViewEngine message extraction generates a variety of legacy formats
for extracted message ids. These formats have a number of issues related
to whitespace handling and reliance upon information inside the original
HTML of a template. The new message format is more resilient to things
like whitespace changes, and can be generated directly from calls to
$localize, which allows messages in application code to have the sameid as identical messages in templates.
As a first step in migrating projects away from the legacy id format
for i18n messages, this commit updates newly generated projects to turn
off the legacy ids.
In the future the default will be flipped and this can be removed.
Eventually the legacy message id support will be removed altogether,
probably in sync with removal of ViewEngine.