Skip to content

fix(@ngtools/webpack): elide type-only imports when using emitDecoratorMetadata #19244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2020
Merged

fix(@ngtools/webpack): elide type-only imports when using emitDecoratorMetadata #19244

merged 1 commit into from
Oct 28, 2020

Conversation

alan-agius4
Copy link
Collaborator

Closes #19234

@google-cla google-cla bot added the cla: yes label Oct 28, 2020
@alan-agius4 alan-agius4 added target: lts This PR is targeting a version currently in long-term support target: patch This PR is targeted for the next patch release labels Oct 28, 2020
@alan-agius4 alan-agius4 requested a review from clydin October 28, 2020 09:18
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 28, 2020
@clydin clydin merged commit 8e11ad9 into angular:master Oct 28, 2020
@alan-agius4 alan-agius4 deleted the ngtools-type-only branch October 28, 2020 14:34
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: lts This PR is targeting a version currently in long-term support target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[@angular-devkit/build-optimizer] Optimization error when using Type-only Imports and emitDecoratorMetadata
2 participants
@alan-agius4 @clydin