Skip to content

Conversation

josephperrott
Copy link
Member

Completes the migration to use the new unified target label system, updating
dependabot, renovate and angular-robot to expect the new labels.

@josephperrott josephperrott added target: patch This PR is targeted for the next patch release action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project labels Dec 9, 2020
@google-cla google-cla bot added the cla: yes label Dec 9, 2020
@josephperrott josephperrott requested a review from kyliau December 10, 2020 00:01
@josephperrott josephperrott force-pushed the finish-pr-merge-migration branch from ab07915 to 6d62f14 Compare December 10, 2020 17:31
Copy link
Contributor

@kyliau kyliau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO you know why we use both dependabot and renovate? Don't they provide the same functionality?

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Dec 10, 2020

dependabot opens PR for transitive security fixes before renovate does AFAIK. renovate supports Bazel workspace updates while dependabot doesn't.

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that you missing replacing PR action: merge with action: merge

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 10, 2020
@josephperrott josephperrott force-pushed the finish-pr-merge-migration branch from 6d62f14 to 61727b5 Compare December 10, 2020 17:52
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alan-agius4 alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Dec 10, 2020
Completes the migration to use the new unified target label system, updating
dependabot, renovate and angular-robot to expect the new labels.
@josephperrott josephperrott force-pushed the finish-pr-merge-migration branch from 61727b5 to 3821927 Compare December 10, 2020 20:49
@filipesilva filipesilva merged commit c6e7da1 into angular:master Dec 11, 2020
@alan-agius4
Copy link
Collaborator

@kyliau it looks like renovate are also handling security fixes. Hence, I think we should probably disable dependabot.

@josephperrott josephperrott deleted the finish-pr-merge-migration branch December 11, 2020 17:04
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants