Skip to content

fix(@schematics/angular): correctly handle PropertyAssignments with StringLiteral keys #19714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2021
Merged

fix(@schematics/angular): correctly handle PropertyAssignments with StringLiteral keys #19714

merged 1 commit into from
Jan 6, 2021

Conversation

alan-agius4
Copy link
Collaborator

Closes #16009

@alan-agius4 alan-agius4 added target: patch This PR is targeted for the next patch release preserve commits labels Jan 5, 2021
@google-cla google-cla bot added the cla: yes label Jan 5, 2021
@alan-agius4 alan-agius4 requested a review from clydin January 5, 2021 10:17
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker preserve commits target: patch This PR is targeted for the next patch release and removed preserve commits action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 5, 2021
@filipesilva filipesilva merged commit 65dac11 into angular:master Jan 6, 2021
@alan-agius4 alan-agius4 deleted the fix-add-declaration branch January 6, 2021 12:09
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Declaration in @NgModule duplicating when generating stuff
3 participants
@alan-agius4 @clydin @filipesilva