ci: update to build_bazel_rules_nodejs version 3 #19716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
preserve commits
target: minor
|
Blocked on angular/angular#40353 |
atscott
pushed a commit
to angular/angular
that referenced
this pull request
Jan 11, 2021
…rsion 3 (#40353) Changes include: - Remove `bazelWorkspaces` as this is no longer supported due to a single version policy bazel-contrib/rules_nodejs#783 and `install_bazel_dependencies` has been removed. - Enable `bazel_patch_module_resolver` since monkey-patch the implementation of `require()` in NodeJS is opt-in More info about the changes can be found here: https://github.com/bazelbuild/rules_nodejs/wiki#migrating-to-30 Blocking: angular/angular-cli#19716 PR Close #40353
clydin
approved these changes
Feb 2, 2021
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More info: https://github.com/bazelbuild/rules_nodejs/wiki#migrating-to-30