Skip to content

Conversation

mattlewis92
Copy link
Contributor

@mattlewis92 mattlewis92 commented Jan 25, 2021

Currently processResults is ignored inside the any, any script, all and all script calculators, so the wrong file size is checked against the budgets. This PR fixes the issue by fetching the correct asset size for es2015 assets from the processResults array.

Fixes #19849

@mattlewis92 mattlewis92 marked this pull request as draft January 25, 2021 16:44
@google-cla google-cla bot added the cla: yes label Jan 25, 2021
@mattlewis92 mattlewis92 force-pushed the issue-19849-test-case branch 2 times, most recently from 03e16d6 to f33bdef Compare January 27, 2021 11:41
@mattlewis92 mattlewis92 changed the title Add failing test for bundle budgets with any script and differential loading Fix bundle budgets with any script and differential loading Jan 27, 2021
@mattlewis92 mattlewis92 marked this pull request as ready for review January 27, 2021 11:44
@mattlewis92 mattlewis92 force-pushed the issue-19849-test-case branch from f33bdef to 95a270e Compare January 27, 2021 11:46
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 28, 2021
@alan-agius4 alan-agius4 merged commit 42e439f into angular:master Jan 28, 2021
@mattlewis92 mattlewis92 deleted the issue-19849-test-case branch January 28, 2021 10:06
@mattlewis92
Copy link
Contributor Author

@alan-agius4 are you able to publish this to angular-devkit-build-angular-builds so I can test it in our app? I don't see the commit in https://github.com/angular/angular-devkit-build-angular-builds

@alan-agius4
Copy link
Collaborator

@alan-agius4 are you able to publish this to angular-devkit-build-angular-builds so I can test it in our app? I don't see the commit in https://github.com/angular/angular-devkit-build-angular-builds

Should be available soon, as I re-triggered CI.

@mattlewis92
Copy link
Contributor Author

@alan-agius4 are you able to publish this to angular-devkit-build-angular-builds so I can test it in our app? I don't see the commit in angular/angular-devkit-build-angular-builds

Should be available soon, as I re-triggered CI.

Thank you so much! 🙌

@mattlewis92
Copy link
Contributor Author

Gave it a go in our app and confirmed the bug is gone and our budgets now pass 😄

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundle budgets incorrectly erroring when differential loading is enabled
2 participants