Skip to content

Conversation

alan-agius4
Copy link
Collaborator

BREAKING CHANGE:

entryComponent option has been removed from the component schematic as this was intended to be used with the the now no longer supported ViewEngine rendering engine.

@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@alan-agius4 alan-agius4 added target: major This PR is targeted for the next major release and removed cla: yes labels Mar 30, 2021
@google-cla google-cla bot added the cla: yes label Mar 30, 2021
@alan-agius4 alan-agius4 requested a review from clydin March 30, 2021 08:39
@angular angular deleted a comment from google-cla bot Mar 30, 2021
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Mar 30, 2021
@filipesilva
Copy link
Contributor

@alan-agius4 this PR is now conflicting, can you rebase please?

@alan-agius4 alan-agius4 added the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 30, 2021
…chematic

BREAKING CHANGE:

`entryComponent` option has been removed from the `component` schematic as this was intended to be used with the the now no longer supported ViewEngine rendering engine.
@alan-agius4
Copy link
Collaborator Author

@filipesilva done.

@alan-agius4 alan-agius4 removed the action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews label Mar 31, 2021
@filipesilva filipesilva merged commit 8582ddc into angular:master Mar 31, 2021
@alan-agius4 alan-agius4 deleted the entry-component branch March 31, 2021 17:00
zarend pushed a commit to angular/angular that referenced this pull request Apr 14, 2021
zarend pushed a commit to angular/angular that referenced this pull request Apr 14, 2021
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants