Skip to content

Windows CI fixes #20461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2021
Merged

Windows CI fixes #20461

merged 1 commit into from
Apr 7, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Apr 7, 2021 •
edited
Loading

Webpack 4 profiling mode fails on Windows with Node.js 14.

@clydin clydin added the target: major This PR is targeted for the next major release label Apr 7, 2021
@google-cla google-cla bot added the cla: yes label Apr 7, 2021
@clydin clydin force-pushed the fix-windows-ci-2 branch from d699db9 to b1a056a Compare April 7, 2021 13:33
@clydin clydin changed the title ci: increase Windows CI Node.js version to 14.6.1 Windows CI fixes Apr 7, 2021
@clydin
ci: adjust Windows CI Node.js version to 12.22.1
d448706 
Webpack 4 profiling mode fails on Windows with Node.js 14.
@clydin clydin force-pushed the fix-windows-ci-2 branch from b1a056a to d448706 Compare April 7, 2021 14:18
@clydin clydin marked this pull request as ready for review April 7, 2021 14:18
alan-agius4
alan-agius4 approved these changes Apr 7, 2021
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking into this.

@alan-agius4 alan-agius4 merged commit 9b25034 into angular:master Apr 7, 2021
@clydin clydin deleted the fix-windows-ci-2 branch April 7, 2021 15:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@clydin @alan-agius4