fix(@angular-devkit/build-angular): provided earlier build feedback in console #20960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
…n console With this change we provide earlier feedback in the console during a build. The setup phase can take some times if the project has a large set of dependencies. We also move several warnings in the dev-server to an earlier phase so that we don't clutter the progress indicator. Closes #20957
alan-agius4
commented
May 27, 2021
| @@ -68,6 +68,42 @@ export function getCommonConfig(wco: WebpackConfigOptions): Configuration { | |||
| buildOptions.differentialLoadingNeeded, | |||
| ); | |||
|
|
|||
| if (buildOptions.progress) { | |||
| const spinner = new Spinner(); | |||
| spinner.start(`Generating ${platform} application bundles (phase: setup)...`); | |||
There was a problem hiding this comment.
This is the root change.
clydin
approved these changes
May 27, 2021
alan-agius4
added a commit
that referenced
this pull request
Jun 4, 2021
With the recent changes in #20960 we moved the spinner to be started outside of the progress callback, this causes a side-effect that after `succeed` is called the spinner will stop reporting progress unless it is started again.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change we provide earlier feedback in the console during a build. The setup phase can take some times if the project has a large set of dependencies.
We also move several warnings in the dev-server to an earlier phase so that we don't clutter the progress indicator.
Closes #20957