Skip to content

Conversation

ddubrava
Copy link
Contributor

Fixes #21023

@google-cla google-cla bot added the cla: yes label Sep 21, 2021
@alan-agius4
Copy link
Collaborator

Hi @ddubrava,

Are you still interested in landing this?

@ddubrava
Copy link
Contributor Author

ddubrava commented Apr 13, 2022

Hi! I’m interested in merging :) so if you want to close the issue (#21023), I will complete this PR (resolve conflicts, concerns)

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Apr 13, 2022

In that case can you please rebase, fix the conflicts and afterwards resolve the failing CI steps by running the below.

yarn bazel run //packages/angular_devkit/schematics:schematics_api.accept
yarn ng-dev format changed

Thanks

@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: minor This PR is targeted for the next minor release labels Apr 13, 2022
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, can you please squash the commits into the first two?

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Apr 18, 2022
@alan-agius4 alan-agius4 merged commit 464cf33 into angular:master Apr 18, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing null options to RunSchematicTask leads to CLI crash
2 participants