Skip to content

Revert "feat(@angular-devkit/build-angular): disable critical CSS inlining by default" #21899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

Revert "feat(@angular-devkit/build-angular): disable critical CSS inlining by default" #21899

merged 1 commit into from
Oct 21, 2021

Conversation

alan-agius4
Copy link
Collaborator

Reverts #21880

@alan-agius4 alan-agius4 added this to the v13 milestone Oct 7, 2021
@google-cla google-cla bot added the cla: yes label Oct 7, 2021
@alan-agius4 alan-agius4 added target: rc This PR is targeted for the next release-candidate and removed cla: yes labels Oct 7, 2021
@google-cla google-cla bot added the cla: yes label Oct 7, 2021
@angular angular deleted a comment from google-cla bot Oct 7, 2021
@alan-agius4 alan-agius4 mentioned this pull request Oct 7, 2021
Merged
@alan-agius4 alan-agius4 requested a review from clydin October 20, 2021 10:56
@alan-agius4 alan-agius4 force-pushed the revert-21880-inline-critical-false branch from 3b128d9 to ba9d3cb Compare October 20, 2021 11:03
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Oct 20, 2021
@alan-agius4 alan-agius4 force-pushed the revert-21880-inline-critical-false branch from ba9d3cb to 5f7476a Compare October 20, 2021 17:55
@filipesilva filipesilva merged commit f3c0c98 into master Oct 21, 2021
@alan-agius4 alan-agius4 deleted the revert-21880-inline-critical-false branch October 21, 2021 09:59
@alan-agius4 alan-agius4 mentioned this pull request Oct 21, 2021
Merged
filipesilva pushed a commit that referenced this pull request Oct 21, 2021
@alan-agius4 @filipesilva
test(@angular-devkit/build-angular): update tests to reflect new outp…
b9bcb8f 
…ut of `critters`

The tests have been re-introduced in the code base via a revert #21899

(cherry picked from commit 03d839f)
filipesilva pushed a commit that referenced this pull request Oct 21, 2021
@alan-agius4 @filipesilva
test(@angular-devkit/build-angular): update tests to reflect new outp…
03d839f 
…ut of `critters`

The tests have been re-introduced in the code base via a revert #21899
@dgp1130 dgp1130 mentioned this pull request Nov 3, 2021
Merged
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@clydin clydin clydin approved these changes

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Milestone
v13-blockers
Development

Successfully merging this pull request may close these issues.
3 participants
@alan-agius4 @clydin @filipesilva