Skip to content

feat(@angular/cli): ask to install angular-eslint when running ng lint in new projects #22203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2021

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 19, 2021

To improve the developer experience for the ng lint command in new projects, the lint command will now ask the developer if they wish to install @angular-eslint/schematics when no lint target has been configured for the specified project. @angular-eslint/schematics is currently the only option listed in the warning shown prior to the introduction of the prompt in this change. If additional example packages are added to the warning text in the future, the confirmation prompt should be changed to a list prompt which would allow the user to pick one of the potential future listed example packages.

Closes: #21387

…t in new projects

To improve the developer experience for the `ng lint` command in new projects, the lint command will now ask the developer if they wish to install `@angular-eslint/schematics` when no lint target has been configured for the specified project. `@angular-eslint/schematics` is currently the only option listed in the warning shown prior to the introduction of the prompt in this change. If additional example packages are added to the warning text in the future, the confirmation prompt should be changed to a list prompt which would allow the user to pick one of the potential future listed example packages.

Closes: angular#21387
@clydin clydin added the target: minor This PR is targeted for the next minor release label Nov 19, 2021
@google-cla google-cla bot added the cla: yes label Nov 19, 2021
@clydin clydin requested a review from alan-agius4 November 19, 2021 16:22
@clydin clydin added the action: review The PR is still awaiting reviews from at least one requested reviewer label Nov 19, 2021
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 22, 2021
@alan-agius4 alan-agius4 merged commit 56f802b into angular:master Nov 22, 2021
@clydin clydin deleted the no-lint-target-dx branch November 22, 2021 11:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improved ng lint experience for new projects
2 participants