build: add pkg_npm rules for remaining packages #22258
Conversation
josephperrott
added
area: build & ci
packages/angular/pwa/BUILD.bazel
Outdated
| # @external_begin | ||
| load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar") | ||
| load("@build_bazel_rules_nodejs//:index.bzl", "pkg_npm") | ||
| # @external_end |
There was a problem hiding this comment.
I added these external tags to follow the existing convention, but I'm not sure what they are used for.
There was a problem hiding this comment.
I was going to ask. It doesn't seem like there is any value in having these as the CLI build files are not exposed publicly anyway.
There was a problem hiding this comment.
These comments were added by @kyliau and were needed for a G3 sync.
There was a problem hiding this comment.
interesting. we should probably re-evaluate (or if @josephperrott already did), whether this is still something we want to maintain long-term. I suspect it will complicate the Bazel migration/maintaince.
There was a problem hiding this comment.
This is something we do not need to include as we do not use our BUILD files internally in g3, we have google3 specific ones.
There was a problem hiding this comment.
Drive by comment: I'm hoping to reevaluate how we integrate the CLI internally to improve the syncing story so we can focus just on the external side here.
I'll remove them. |
|
I removed the |
| @@ -6,6 +6,8 @@ | |||
| load("@npm//@bazel/jasmine:index.bzl", "jasmine_node_test") | |||
| load("//tools:defaults.bzl", "ts_library") | |||
| load("//tools:ts_json_schema.bzl", "ts_json_schema") | |||
| load("@bazel_tools//tools/build_defs/pkg:pkg.bzl", "pkg_tar") | |||
There was a problem hiding this comment.
FYI: the pkg_tar rule from bazel_tools is deprecated and does not work on Windows. https://docs.bazel.build/versions/main/be/pkg.html
Not necessarily blocking for this PR as it probably is used elsewhere in the repo, but just a heads up.
There was a problem hiding this comment.
Noted. I'll look into changing those rules before the bazel built packages actually get used.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Before re-writing the
build.tsscript to use bazel for building, I thought a good place to start would be to add some missing rules. Three of the packages built bybuild.tsdidn't have correspondingpkg_npmtargets.