-
Notifications
You must be signed in to change notification settings - Fork 11.9k
Don't set TAILWIND_MODE=watch #22447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set TAILWIND_MODE=watch #22447
Conversation
This was only used as a workaround for older postcss-loder versions. It is no longer necessary. Additionaly it does not work with polling.
9e72bac
to
70dfcda
Compare
Creator of Tailwind here — co-signed, this isn't necessary and only introduces problems. |
@alan-agius4, do we also want this in patch? Seems like it could be shipped before 13.2? |
Just a quick follow-up, we've already removed this from Tailwind in recent releases (removed in 3.0.9 and we're on 3.0.12 now), so the code this PR removes is already just doing nothing for anyone who is on the latest Tailwind 👍🏻 |
Any updates on this? I still can't have this working. I have to rerun ng serve everytime I add a class that is not added before. |
This will go out in 13.2 which is scheduled in less than 24 hours, so it should be fixed shortly. |
A, okay. I will try that later ... Btw, fix doesn't seems to work either :/ |
update to angular 13.2. not fix this problem :( |
Problem is solved. I need manualy uninstall and install devDependencies "@angular-devkit/build-angular": "^13.2.0", |
It works for me as well. Thank you guys! |
upgraded from Angular 13.0 to 13.2.2 via the Angular CLI command |
Problem solved. Thank you guys! |
Also worked for me, upgraded from v12 to v13, and fixed the problem. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This env var only now exists as a workaround for older
postcss-loader
versions that don't support build dependencies. It is not necessary when using postcss-loader >= 5.3. Additionally it does not work with polling. This shows itself when running docker containers on Windows which require angular to poll for changes because filesystem events from volumes are not delivered to the container.Internally we use postcss dependencies and rely on the build tool running tailwind to track file changes for us. Using
TAILWIND_MODE=watch
sidesteps that entirely and causes tailwind to watch files for changes itself. We only use this as a workaround for when tools aren't behaving properly.The relevant issue on tailwindcss is here: tailwindlabs/tailwindcss#6343
Relevant PostCSS discussion: postcss/postcss#1537