Skip to content

Conversation

bbarry
Copy link
Contributor

@bbarry bbarry commented Jan 10, 2022

Currently when making a change while serving a localized application, duplicate
translation warnings appear for every translation id. This fixes that by
replacing the whole translation object with a new one each time translations
are loaded.

fixes #22398

@bbarry
Copy link
Contributor Author

bbarry commented Jan 10, 2022

CLA signed

@alan-agius4 alan-agius4 reopened this Jan 10, 2022
@alan-agius4 alan-agius4 requested review from clydin and removed request for clydin January 10, 2022 14:40
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jan 11, 2022
@alan-agius4 alan-agius4 force-pushed the patch-1 branch 2 times, most recently from a65d25e to b3f715d Compare January 11, 2022 07:57
Currently when making a change while serving a localized application, duplicate
translation warnings appear for every translation id. This fixes that by
replacing the whole translation object with a new one each time translations
are loaded.

fixes angular#22398
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Feb 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants