fix(@angular-devkit/build-angular): automatically purge stale build cache entries #22473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: patch
alan-agius4
changed the title
dgp1130
approved these changes
Jan 11, 2022
packages/angular_devkit/build_angular/src/builders/server/index.ts
Outdated
Show resolved
Hide resolved
| } else { | ||
| await rmdir(entryPath, { recursive: true, maxRetries: 3 }); | ||
| } | ||
| } catch {} |
There was a problem hiding this comment.
I feel like I just saw this snippet in another PR, is this a common pattern in the CLI? Would it be worth factoring this out to something reusable?
There was a problem hiding this comment.
Yeah, I can do that once both PRs are merged.
There was a problem hiding this comment.
Actually the other PR is using the sync version.
There was a problem hiding this comment.
Up to you whether it's worth merging them, just something I noticed looking through it.
…ache entries With every build-angular release, previously created cache entries get stale and are no longer used. This causes the cache to keep growing as older files are not purged. With this change we automatically purge entries that have been created with older version of build-angular and can no longer be used with the current installed version. Closes #22323
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With every build-angular release, previously created cache entries get stale and are no longer used. This causes the cache to keep growing as older files are not purged.
With this change we automatically purge entries that have been created with older version of build-angular and can no longer be used with the current installed version.
Closes #22323