fix(@angular-devkit/build-angular): handle service-worker serving with localize in dev-server #23849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
force-pushed
the
fix/dev-server-sw-localize
branch
2 times, most recently
from
75d332b to
42555d8
Compare
…h localize in dev-server Previously, we tried to read the files from the wrong location as during localize we alter the output directory to a different temporary location. https://github.com/angular/angular-cli/blob/7e64b1537d54fadb650559214fbb12707324cd75/packages/angular_devkit/build_angular/src/utils/i18n-options.ts#L251-L252 Closes angular#23844
alan-agius4
force-pushed
the
fix/dev-server-sw-localize
branch
from
42555d8 to
cd0a6a1
Compare
alan-agius4
added
action: review
clydin
approved these changes
Sep 2, 2022
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we tried to read the files from the wrong location as during localize we alter the output directory to a different temporary location.
angular-cli/packages/angular_devkit/build_angular/src/utils/i18n-options.ts
Lines 251 to 252 in 7e64b15
Closes #23844