Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Oct 24, 2022

With this change we add a long description to analytics command with the information that is currently contain in https://angular.io/analytics which will be deleted at a later stage.

@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 24, 2022
@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate and removed area: docs Related to the documentation labels Oct 24, 2022
@alan-agius4 alan-agius4 force-pushed the docs-analytics-v15-update branch from 6bf8e46 to d84a062 Compare October 24, 2022 08:13
@angular-robot angular-robot bot added the area: docs Related to the documentation label Oct 24, 2022
@alan-agius4 alan-agius4 requested review from dgp1130 and clydin October 24, 2022 08:13
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo in commit message: "information that is currently contained in".

Also what's the motivation behind dropping angular.io/analytics? Is there more context here?

@alan-agius4 alan-agius4 removed the request for review from clydin October 24, 2022 18:29
@alan-agius4
Copy link
Collaborator Author

The motivation behind dropping angular.io/analytics. Is that at the moment we have 3 pages describing analytics. The majority of which have duplicate content. With this change we move all content to the analytics command page.

This page was also not linked from the AIO guide which made it hard to discover as the only link was in the footer.

With this change we add a long description to analytics command with the information that is currently contained in https://angular.io/analytics which will be deleted at a later stage.
@alan-agius4 alan-agius4 force-pushed the docs-analytics-v15-update branch from d84a062 to 086f9f1 Compare October 24, 2022 18:32
Copy link
Collaborator

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I've been confused by the duplicate pages in the past too. +1 to simplifying them.

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 24, 2022
@dgp1130 dgp1130 merged commit 82cb049 into angular:main Oct 24, 2022
@alan-agius4 alan-agius4 deleted the docs-analytics-v15-update branch October 24, 2022 22:28
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants