Skip to content

perf(@angular-devkit/build-angular): avoid template diagnostics for declaration files in esbuild builder #24135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2022
Merged

perf(@angular-devkit/build-angular): avoid template diagnostics for declaration files in esbuild builder #24135

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/angular_devkit/build_angular/src/builders/browser-esbuild/compiler-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,11 @@ export function createCompilerPlugin(
true,
);

// Declaration files cannot have template diagnostics
if (sourceFile.isDeclarationFile) {
continue;
}

// Only request Angular template diagnostics for affected files to avoid
// overhead of template diagnostics for unchanged files.
if (affectedFiles.has(sourceFile)) {
Expand Down