Skip to content

Conversation

alan-agius4
Copy link
Collaborator

@alan-agius4 alan-agius4 commented Dec 5, 2022

G3 is now using RXJS version 7 which makes it possible for the CLI to also be updated to RXJS 7.

NB: this change does not remove all usages of the deprecated APIs.

Closes #24371

@angular-robot angular-robot bot added the area: build & ci Related the build and CI infrastructure of the project label Dec 5, 2022
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Dec 5, 2022
@alan-agius4 alan-agius4 marked this pull request as ready for review December 5, 2022 12:21
@alan-agius4 alan-agius4 requested a review from clydin December 5, 2022 12:43
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Dec 5, 2022
@angular-robot angular-robot bot added detected: deprecation PR contains a commit with a deprecation detected: feature PR contains a feature commit labels Dec 6, 2022
@alan-agius4 alan-agius4 force-pushed the rxjs-7 branch 4 times, most recently from 29aa807 to f74bfa3 Compare December 6, 2022 10:35
@alan-agius4 alan-agius4 requested a review from clydin December 6, 2022 11:00
@alan-agius4 alan-agius4 force-pushed the rxjs-7 branch 9 times, most recently from c234a7f to e31a4c6 Compare December 8, 2022 12:35
@alan-agius4 alan-agius4 removed detected: feature PR contains a feature commit detected: deprecation PR contains a commit with a deprecation labels Dec 9, 2022
@alan-agius4 alan-agius4 force-pushed the rxjs-7 branch 2 times, most recently from 3d11294 to bb4fb4c Compare December 14, 2022 09:43
@alan-agius4 alan-agius4 force-pushed the rxjs-7 branch 2 times, most recently from ac3fb82 to fc30562 Compare December 19, 2022 11:40
@alan-agius4
Copy link
Collaborator Author

@clydin PTAL

@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed action: review The PR is still awaiting reviews from at least one requested reviewer action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release labels Dec 19, 2022
@HyperLife1119
Copy link
Contributor

Should the 'rxjs/operators' import point also be replaced with 'rxjs'?
https://rxjs.dev/guide/importing#new-in-rxjs-v720

G3 is now using RXJS version 7 which makes it possible for the CLI to also be updated to RXJS 7.

NB: this change does not remove all usages of the deprecated APIs.

Closes angular#24371
@alan-agius4 alan-agius4 force-pushed the rxjs-7 branch 2 times, most recently from 25e2d3c to f2a8d3a Compare February 16, 2023 14:19
@alan-agius4 alan-agius4 added the action: merge The PR is ready for merge by the caretaker label Feb 16, 2023
@angular-robot angular-robot bot merged commit 8095268 into angular:main Feb 16, 2023
@alan-agius4 alan-agius4 deleted the rxjs-7 branch February 16, 2023 15:31
@alan-agius4 alan-agius4 restored the rxjs-7 branch February 16, 2023 15:31
@alan-agius4 alan-agius4 deleted the rxjs-7 branch February 16, 2023 15:31
@alan-agius4 alan-agius4 restored the rxjs-7 branch February 16, 2023 15:31
@alan-agius4 alan-agius4 deleted the rxjs-7 branch February 16, 2023 15:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update rxjs to v7.x
3 participants