fix(@angular-devkit/build-angular): set public class fields as properties #24849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
the
target: major
alan-agius4
force-pushed
the
babel-public-fields
branch
from
6e051c9 to
9d88740
Compare
…ties Configure Babel to use `setPublicClassFields: true`. As when shipping Angular packages without `"useDefineForClassFields": false` will increase the bundle size of an ng-new app by ~2Kb when `useDefineForClassFields` is not false. due to the additional `_defineProperty`, which will be added on every class property. See: https://babeljs.io/docs/babel-plugin-proposal-class-properties
alan-agius4
force-pushed
the
babel-public-fields
branch
from
9d88740 to
bee2dde
Compare
alan-agius4
added
the
action: review
clydin
reviewed
Mar 13, 2023
packages/angular_devkit/build_angular/src/webpack/configs/common.ts
Outdated
Show resolved
Hide resolved
… properties Co-authored-by: Charles <19598772+clydin@users.noreply.github.com>
clydin
approved these changes
Mar 13, 2023
alan-agius4
added
area: docs
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Configure Babel to use
setPublicClassFields: true. As when shipping Angular packages without"useDefineForClassFields": falsewill increase the bundle size of an ng-new app by ~2Kb whenuseDefineForClassFieldsis not false. due to the additional_defineProperty, which will be added on every class property.See: https://babeljs.io/docs/babel-plugin-proposal-class-properties