Account for string literals in styles and the new styleUrls #25812
Conversation
crisbeto
added
action: review
| @@ -143,82 +143,93 @@ function visitComponentMetadata( | |||
| switch (node.name.text) { | |||
| case 'templateUrl': | |||
| // Only analyze string literals | |||
| if ( | |||
There was a problem hiding this comment.
Note: I couldn't figure out where this logic is tested so I didn't add any tests. I can add some if somebody can point me in the right direction.
There was a problem hiding this comment.
You can add a test similar to https://github.com/angular/angular-cli/blob/734a46e99ff94d5fffd93f223e4b2b7646790f78/packages/angular_devkit/build_angular/src/builders/application/tests/behavior/component-stylesheets_spec.ts or an E2E https://github.com/angular/angular-cli/tree/main/tests/legacy-cli/e2e/tests/build
There was a problem hiding this comment.
Hmm okay, it looks like I can't write a test there, because the change hasn't landed in a release yet so writing a component with the new properties results in a compilation error.
There was a problem hiding this comment.
Actually even if this compiled, it wouldn't be testing the behavior we're looking for, because the transformer only runs on JIT code. As far as I can tell, these tests are running AOT compilation.
There was a problem hiding this comment.
Actually even if this compiled, it wouldn't be testing the behavior we're looking for, because the transformer only runs on JIT code. As far as I can tell, these tests are running AOT compilation.
You can switch between AOT and JIT by providing the aot as an option in
Let's land it for now, and follow up with a unit test in a separate PR once the changes in the FW are released on NPM.
crisbeto
changed the title
…s and styleUrl An upcoming change in Angular will allow `style` specified as strings, in addition to a new `styleUrl` property. These changes update the Webpack transform to support the change.
…tring literals and styleUrl An upcoming change in Angular will allow `style` specified as strings, in addition to a new `styleUrl` property. These changes update the JIT resource transform to support the change.
crisbeto
force-pushed
the
string-literal-styles
branch
from
134b715
to
734a46e
Compare
crisbeto
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Updates the JIT transformers to account for the upcoming changes from angular/angular#51715.