Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(@angular-devkit/build-angular): skip checking CommonJS module descendants #26169

Merged
merged 1 commit into from Oct 30, 2023
Merged

fix(@angular-devkit/build-angular): skip checking CommonJS module descendants #26169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions packages/angular_devkit/build_angular/src/tools/esbuild/commonjs-checker.ts
View file
Open in desktop
Expand Up @@ -104,11 +104,12 @@ export function checkCommonJSModules(
}

if (notAllowed) {
// Issue a diagnostic message and skip all descendants since they are also most
// likely not ESM but solved by addressing this import.
// Issue a diagnostic message for CommonJS module
messages.push(createCommonJSModuleError(request, currentFile));
continue;
}

// Skip all descendants since they are also most likely not ESM but solved by addressing this import
continue;
}

// Add the path so that its imports can be checked
Expand Down