Skip to content

fix(@angular-devkit/build-angular): Windows Node.js 20 prerendering failure #26186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix(@angular-devkit/build-angular): Windows Node.js 20 prerendering failure #26186

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5373d91
fix(@angular-devkit/build-angular): Windows Node.js 20 prerendering f…
alan-agius4 Oct 31, 2023
e4b8b61
fixup! fix(@angular-devkit/build-angular): Windows Node.js 20 prerend…
alan-agius4 Oct 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...ular_devkit/build_angular/src/utils/server-rendering/esm-in-memory-loader/loader-hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,10 @@ export function resolve(
}

export async function load(url: string, context: { format?: string | null }, nextLoad: Function) {
if (isFileProtocol(url)) {
const { format } = context;

// CommonJs modules require no transformations and are not in memory.
if (format !== 'commonjs' && isFileProtocol(url)) {
const filePath = fileURLToPath(url);
// Remove '/' or drive letter for Windows that was added in the above 'resolve'.
let source = outputFiles[relative('/', filePath)] ?? TRANSFORMED_FILES[filePath];
Expand All @@ -81,8 +84,6 @@ export async function load(url: string, context: { format?: string | null }, nex
}

if (source !== undefined) {
const { format } = context;

return {
format,
shortCircuit: true,
Expand Down