fix(@angular-devkit/build-angular): prebundle dependencies for SSR when using Vite #26202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: rc
alan-agius4
force-pushed
the
pre-bundle-ssr-dep-vite
branch
from
69421d7 to
0aa9d9b
Compare
clydin
approved these changes
Nov 2, 2023
alan-agius4
changed the title
…en using Vite The commit introduces dependencies prebundling and optimisation for SSR dependencies. This is primarily needed for Angular linking and async/await downlevelling. To enable this, we need to use the undocumented `optimizeDeps` setting under the `ssr` option. This is because, the top level `optimizeDeps` vite config option only controls browser dependencies. For the above mentioned option to take effect and transform node packages, we also need to use `noExternal` and use a catch all `RegExp`. Note: setting this option to `true` has a different effect from a catch all `RegExp`, as the former will cause the `external` option to be ignored. Additionally together with `externalMetadata.explicit` we add Node.js build-ins as `external`. Closes: angular#26192
alan-agius4
force-pushed
the
pre-bundle-ssr-dep-vite
branch
from
0aa9d9b to
a28fa09
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The commit introduces dependencies prebundling and optimisation for SSR dependencies. This is primarily needed for Angular linking and async/await downlevelling. To enable this, we need to use the undocumented
optimizeDepssetting under thessroption. This is because, the top leveloptimizeDepsvite config option only controls browser dependencies.For the above mentioned option to take effect and transform node packages, we also need to use
noExternaland use a catch allRegExp. Note: setting this option totruehas a different effect from a catch allRegExp, as the former will cause theexternaloption to be ignored.Additionally together with
externalMetadata.explicitwe add Node.js build-ins asexternal.Closes: #26192