Skip to content

perf(@angular-devkit/build-angular): start SSR dependencies optimization before the first request #26231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2023
Merged

perf(@angular-devkit/build-angular): start SSR dependencies optimization before the first request #26231

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 13 additions & 1 deletion packages/angular_devkit/build_angular/src/builders/dev-server/vite-server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,8 +216,20 @@ export async function* serveWithVite(
);

server = await createServer(serverConfiguration);

await server.listen();

if (browserOptions.ssr) {
/**
* Vite will only start dependency optimization of SSR modules when the first request comes in.
* In some cases, this causes a long waiting time. To mitigate this, we call `ssrLoadModule` to
* initiate this process before the first request.
*
* NOTE: This will intentionally fail from the unknown module, but currently there is no other way
* to initiate the SSR dep optimizer.
*/
void server.ssrLoadModule('<deps-caller>').catch(() => {});
}

const urls = server.resolvedUrls;
if (urls && (urls.local.length || urls.network.length)) {
serverUrl = new URL(urls.local[0] ?? urls.network[0]);
Expand Down