Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 6, 2023

When using the application builder, exceptions thrown by the AOT compiler will now be converted into error diagnostics. This allows for more actionable information to be displayed in the build output. It also prevents the typically incorrect "missing file" error from occurring in these cases which previously occurred due to TypeScript files not being emitted as a result of the compiler failure.

…nto diagnostics

When using the `application` builder, exceptions thrown by the AOT compiler will
now be converted into error diagnostics. This allows for more actionable information
to be displayed in the build output. It also prevents the typically incorrect "missing
file" error from occurring in these cases which previously occurred due to TypeScript
files not being emitted as a result of the compiler failure.
@clydin clydin requested a review from alan-agius4 November 6, 2023 17:44
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate labels Nov 6, 2023
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Nov 6, 2023
@alan-agius4 alan-agius4 merged commit f76e1a0 into angular:main Nov 6, 2023
@clydin clydin deleted the esbuild/aot-failure-diags branch November 6, 2023 17:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants