Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented Dec 4, 2023

The latest major (v6) of the typescript eslint plugin contains several new rule defaults that currently cause errors in the repository code while linting. To facilitate an upgrade, these rules are now preemptively disabled. Once the update is complete, these rules can be evaluated for inclusion.

The rules are as follows:

  • @typescript-eslint/no-unsafe-enum-comparison
  • @typescript-eslint/no-redundant-type-constituents
  • @typescript-eslint/no-base-to-string

Unblocks #25522

…grading

The latest major (v6) of the typescript eslint plugin contains several new rule
defaults that currently cause errors in the repository code while linting. To
facilitate an upgrade, these rules are now preemptively disabled. Once the update
is complete, these rules can be evaluated for inclusion.

The rules are as follows:
   * @typescript-eslint/no-unsafe-enum-comparison
   * @typescript-eslint/no-redundant-type-constituents
   * @typescript-eslint/no-base-to-string
@clydin clydin added action: review The PR is still awaiting reviews from at least one requested reviewer target: minor This PR is targeted for the next minor release labels Dec 4, 2023
@dgp1130 dgp1130 self-requested a review December 4, 2023 21:45
@clydin clydin added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Dec 4, 2023
@clydin clydin merged commit c76fd28 into angular:main Dec 4, 2023
@clydin clydin deleted the test/lint-update-prep branch December 4, 2023 21:46
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants