fix(@angular-devkit/build-angular): correctly handle glob negation in proxy config when using vite #26974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
action: review
alan-agius4
force-pushed
the
negate-glob
branch
from
ed0b573 to
69dfcdb
Compare
clydin
reviewed
Jan 26, 2024
packages/angular_devkit/build_angular/src/utils/load-proxy-config.ts
Outdated
Show resolved
Hide resolved
alan-agius4
force-pushed
the
negate-glob
branch
2 times, most recently
from
926e1e2 to
6829070
Compare
clydin
reviewed
Jan 26, 2024
...ages/angular_devkit/build_angular/src/builders/dev-server/tests/options/proxy-config_spec.ts
Outdated
Show resolved
Hide resolved
clydin
approved these changes
Jan 26, 2024
… proxy config when using vite This commit fixes an issue were negated globs in proxy config were not process correctly when using vite. Closes angular#26970
alan-agius4
force-pushed
the
negate-glob
branch
from
6829070 to
53ccf55
Compare
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue were negated globs in proxy config were not process correctly when using vite.
Closes #26970