-
Notifications
You must be signed in to change notification settings - Fork 11.9k
fix(@schematics/angular): rename SSR port env variable #27333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@schematics/angular): rename SSR port env variable #27333
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also please add more context in the commit body? Example:
Linking to firebase/firebase-tools#6651 (comment) and explaining that PORT
is reserved variable as per https://firebase.google.com/docs/functions/config-env?gen=2nd#reserved-names?
Additionally the scope should be @schematics/angular
, the type can also be a fix
.
packages/angular_devkit/build_angular/src/builders/ssr-dev-server/index.ts
Outdated
Show resolved
Hide resolved
c8a9af4
to
7c195cd
Compare
Rename the SSR port env variable to SSR_PORT. It could help to resolve this firebase issue: firebase/firebase-tools#6651 (comment), cause PORT is reserved environment variable: https://firebase.google.com/docs/functions/config-env?gen=2nd#reserved-names.
7c195cd
to
e1ddc1a
Compare
This actually breaks Firebase on deploy. PORT is a reserved variable because it's what Functions and Run uses to set the port to listen to. Let's collaborate on a working solution. |
@inlined, should we revert this? |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Rename SSR port env variable to SSR_PORT.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Rename the SSR port env variable to SSR_PORT.
It could help to resolve this firebase issue: firebase/firebase-tools#6651 (comment), cause PORT is reserved environment variable: https://firebase.google.com/docs/functions/config-env?gen=2nd#reserved-names.
Does this PR introduce a breaking change?
Other information