Skip to content

Conversation

clydin
Copy link
Member

@clydin clydin commented May 2, 2024

To remove the potential for a large amount of modulepreload link elements being added to the generating index.html for an application, the number of elements is now limited to five. Also, only first-level initial scripts will be added. Previously all initial scripts regardless of depth were eligible for preloading. The preload generation can still be fully disabled via the index.preloadInitial option within the build options.

@clydin clydin added the target: rc This PR is targeted for the next release-candidate label May 2, 2024
@clydin clydin marked this pull request as ready for review May 2, 2024 15:08
@clydin clydin requested a review from alan-agius4 May 2, 2024 15:08
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: the scope should be @angular/build.

@clydin clydin force-pushed the application/shallow-preloads branch 2 times, most recently from 47c73ca to f2ae94f Compare May 2, 2024 15:44
@clydin clydin changed the title fix(@angular-devkit/build-angular): only generate shallow preload links for initial files fix(@build/angular): only generate shallow preload links for initial files May 2, 2024
@clydin clydin changed the title fix(@build/angular): only generate shallow preload links for initial files fix(@angular/build): only generate shallow preload links for initial files May 2, 2024
…files

To remove the potential for a large amount of modulepreload link elements being added
to the generating `index.html` for an application, the number of elements is now limited
to three. Also, only first-level initial scripts will be added. Previously all initial
scripts regardless of depth were eligible for preloading. The preload generation can
still be fully disabled via the `index.preloadInitial` option within the build options.
@clydin clydin force-pushed the application/shallow-preloads branch from f2ae94f to 131fdb5 Compare May 2, 2024 15:50
@clydin clydin added the action: merge The PR is ready for merge by the caretaker label May 2, 2024
@clydin clydin merged commit 82e9e68 into angular:main May 2, 2024
@clydin clydin deleted the application/shallow-preloads branch May 2, 2024 16:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: rc This PR is targeted for the next release-candidate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants