refactor(@angular/build): support dev server direct component style serving #28231
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clydin
force-pushed
the
dev-server/component-styles
branch
from
764708f to
a829879
Compare
clydin
force-pushed
the
dev-server/component-styles
branch
from
a829879 to
a374690
Compare
clydin
changed the title
clydin
force-pushed
the
dev-server/component-styles
branch
from
a374690 to
2b37d27
Compare
clydin
force-pushed
the
dev-server/component-styles
branch
2 times, most recently
from
35ff2d4 to
584faba
Compare
clydin
force-pushed
the
dev-server/component-styles
branch
2 times, most recently
from
9712dc6 to
92de505
Compare
clydin
added
the
action: review
alan-agius4
reviewed
Sep 12, 2024
packages/angular/build/src/tools/vite/middlewares/assets-middleware.ts
Outdated
Show resolved
Hide resolved
…erving The Vite-based development server now provides support for serving individual component stylesheets both with and without emulated view encapsulation. This capability is not yet used by the Angular runtime code. The ability to use external stylesheets instead of bundling the style content is an enabling capability primarily for automatic component style HMR features. Additionally, it has potential future benefits for development mode deferred style processing which may reduce the initial build time when using the development server. The application build itself also does not yet generate external stylesheets.
clydin
force-pushed
the
dev-server/component-styles
branch
from
92de505 to
9f7e2c4
Compare
alan-agius4
approved these changes
Sep 12, 2024
alan-agius4
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Vite-based development server now provides support for serving individual component stylesheets both with and without emulated view encapsulation. This capability is not yet used by the Angular runtime code. The ability to use external stylesheets instead of bundling the style content is an enabling capability primarily for automatic component style HMR features. Additionally, it has potential future benefits for development mode deferred style processing which may reduce the initial build time when using the development server. The application build itself also does not yet generate external stylesheets.