Skip to content

refactor(@angular/build): add explicit type annotations to avoid inferred types #28389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 10, 2024
Merged

refactor(@angular/build): add explicit type annotations to avoid inferred types #28389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion packages/angular/build/src/tools/sass/worker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,29 @@ interface RenderRequestMessage {
rebase: boolean;
}

export default async function renderSassStylesheet(request: RenderRequestMessage) {
interface RenderResult {
warnings: SerializableWarningMessage[] | undefined;
result: {
css: string;
loadedUrls: string[];
sourceMap?: RawSourceMap;
};
}

interface RenderError {
warnings: SerializableWarningMessage[] | undefined;
error: {
message: string;
stack?: string;
span?: Omit<SourceSpan, 'url'> & { url?: string };
sassMessage?: string;
sassStack?: string;
};
}

export default async function renderSassStylesheet(
request: RenderRequestMessage,
): Promise<RenderResult | RenderError> {
const { importerChannel, hasLogger, source, options, rebase } = request;

const entryDirectory = dirname(options.url);
Expand Down Expand Up @@ -164,6 +186,7 @@ export default async function renderSassStylesheet(request: RenderRequestMessage
warnings,
result: {
...result,
sourceMap: result.sourceMap as unknown as RawSourceMap | undefined,
// URL is not serializable so to convert to string here and back to URL in the parent.
loadedUrls: result.loadedUrls.map((p) => fileURLToPath(p)),
},
Expand Down
Loading