feat(@schematics/angular): add option to setup new workspace or appli…

[aparzi]

Introduces option --experimental-zoneless to setup workspace or application as zoneless mode.

PR Checklist

Please check to confirm your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/angular/angular-cli/blob/main/CONTRIBUTING.md#-commit-message-guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

• Bugfix
• Feature
• Code style update (formatting, local variables)
• Refactoring (no functional changes, no api changes)
• Build related changes
• CI related changes
• Documentation content changes
• Other... Please describe:

What is the current behavior?

Closes #28370

Does this PR introduce a breaking change?

• Yes
• No

[aparzi]

Hi @alan-agius4,
Based on the email exchange we had, I created the draft PR, to check the reason why it does not recognize the experimental-zoneless option and possibly give me some feedback and suggestions.

Thanks.

[alan-agius4]

Thanks for this, overall this looks good.

Would be great if you can also add some UTs.

[aparzi]

Hi @alan-agius4,
I updated the PR according to the requested changes. I added a test case, the only thing running the command yarn bazel test //packages/schematics/angular:angular_test seems to give the following error:
SyntaxError: Unexpected token ')'.
This however even without writing new test cases, seems to be related to the runSchematic method used in the .spec files

[alan-agius4]

Hi @alan-agius4, I updated the PR according to the requested changes. I added a test case, the only thing running the command yarn bazel test //packages/schematics/angular:angular_test seems to give the following error: SyntaxError: Unexpected token ')'. This however even without writing new test cases, seems to be related to the runSchematic method used in the .spec files

The problem is that in the templates, you have missing some <%.

[aparzi]

Hi @alan-agius4,
I will adjust the PR as soon as possible. Can you also tell me why when I run the command ng new [angular_project_name] --experimental-zoneless it gives me an error saying that the option is not recognized?

[alan-agius4]

Can you also tell me why when I run the command ng new [angular_project_name] --experimental-zoneless it gives me an error saying that the option is not recognized?

Likely because you do globally you do not have the local copy

[aparzi]

Hi @alan-agius4,
I updated the PR according to the requested changes and some improvements and added the test cases. I'm waiting for news.

Thanks

[alan-agius4]

Thank you for your contribution! I’ve provided some feedback for you.

[aparzi]

Hi @alan-agius4,
I updated this PR

[aparzi]

@alan-agius4 I believe all request changes done.

[aparzi]

Hi @alan-agius4,
I updated this PR. Let me know if everything is ok.

Many thanks.

[alan-agius4]

thanks, see above.

[aparzi]

Hi @alan-agius4,
I have updated the PR with the requested changes. Sorry for the inconvenience.

Many thanks.

[alan-agius4]

Thanks, there are still a few issues.

[aparzi]

Thanks, there are still a few issues.

Ok thanks, I have updated the PR with the requested changes.

[alan-agius4]

Thanks again for this, almost there.

[aparzi]

Thanks again for this, almost there.

I think I did everything. I just have doubts about e2e if they pass, I tried to follow what you suggested.

Thanks again.

[aparzi]

@alan-agius4
I updated the PR adding the requested change in app.module. To be safe I also added two more test cases, after this change.

Thanks I'm waiting

[alan-agius4]

LGTM, thanks

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}