Skip to content

Conversation

dgp1130
Copy link
Collaborator

@dgp1130 dgp1130 commented Oct 14, 2024

This renames the Protractor builder and its e2e generator schematic to mark them private and remove them from Angular's public API. This will give us an opportunity to clean up internal usages and then remove the builder altogether in a future release. Since this rename makes Protractor non-public API, it may be completely deleted in a future patch release.

Protractor was marked end-of-life in August 2023. Projects still relying on Protractor should consider migrating to another E2E testing framework, several support solid migration paths from Protractor.

Additional resources:

@angular-robot angular-robot bot added detected: breaking change PR contains a commit with a breaking change area: @angular-devkit/build-angular labels Oct 14, 2024
@dgp1130 dgp1130 added the target: major This PR is targeted for the next major release label Oct 15, 2024
@dgp1130 dgp1130 added this to the v19 Candidates milestone Oct 15, 2024
…d schematics

BREAKING CHANGE: Protractor is no longer supported.

Protractor was marked end-of-life in August 2023 (see https://protractortest.org/). Projects still relying on Protractor should consider migrating to another E2E testing framework, several support solid migration paths from Protractor.

* https://angular.dev/tools/cli/end-to-end
* https://blog.angular.dev/the-state-of-end-to-end-testing-with-angular-d175f751cb9c
@dgp1130 dgp1130 marked this pull request as ready for review October 18, 2024 23:18
@dgp1130 dgp1130 requested review from alan-agius4 and clydin October 18, 2024 23:18
@dgp1130
Copy link
Collaborator Author

dgp1130 commented Oct 18, 2024

I patched this change into the FW and Components repos. angular/angular#58254 should be enough to update FW. Components actually doesn't seem to be affected at all. All their Protractor usage comes through Bazel, they don't invoke it through Angular CLI.

Once this lands, we should do another next release and then I'll change angular/angular#58254 to include this update of Angular CLI with those Protractor fixes to avoid any internal breakages from this change.

@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 21, 2024
"my-app-e2e": {
"root": "e2e/",
"projectType": "application",
"prefix": "",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any changes with core can be reverted as this are just test file.

@dgp1130 dgp1130 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 21, 2024
@dgp1130 dgp1130 removed the request for review from clydin October 21, 2024 21:49
@dgp1130 dgp1130 merged commit 03d4bd2 into angular:main Oct 21, 2024
33 checks passed
@dgp1130 dgp1130 deleted the rm-protractor branch October 21, 2024 21:50
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker area: @angular-devkit/build-angular detected: breaking change PR contains a commit with a breaking change target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants