refactor(@angular/build): add internal support for generating template update functions #28672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e update functions The internal AOT Angular compilation processing can now generate the newly introduced template update functions during development server rebuilds of template only file changes. These template update functions are not yet used but provide the infrastructure to enable template hot replacement in a future change.
clydin
added
the
action: review
alan-agius4
reviewed
Oct 21, 2024
Comment on lines
+428
to
+429
| const lowerFile = file.toLowerCase(); | ||
| if (lowerFile.endsWith('.html') || lowerFile.endsWith('.svg')) { |
There was a problem hiding this comment.
NIT:
Suggested change
| const lowerFile = file.toLowerCase(); | |
| if (lowerFile.endsWith('.html') || lowerFile.endsWith('.svg')) { | |
| const ext = extname(file).toLowerCase(); | |
| if (ext === '.html' || ext === '.svg') { |
Or also
return [...modifiedFiles].every(file => /\.(html|svg)$/i.test(file));
alan-agius4
approved these changes
Oct 21, 2024
clydin
added
action: merge
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal AOT Angular compilation processing can now generate the newly introduced template update functions during development server rebuilds of template only file changes. These template update functions are not yet used but provide the infrastructure to enable template hot replacement in a future change.