Skip to content

Conversation

alan-agius4
Copy link
Collaborator

fix(@angular/build): simplify disabling server features with --no-server via command line

When outputMode is configured, --prerender and --app-shell become no-ops, making server feature disabling difficult without modifying the configuration.

This commit introduces the --no-server option, which can be used with --output-mode static to fully disable all server features.

ng build --output-mode static --no-server

fix(@angular/build): add warning when --prerendering or --app-shell are no-ops

Both options are ineffective when used with outputMode, so a warning is now issued.

…l` are no-ops

Both options are ineffective when used with `outputMode`, so a warning is now issued.
…rver` via command line

When `outputMode` is configured, `--prerender` and `--app-shell` become no-ops, making server feature disabling difficult without modifying the configuration.

This commit introduces the `--no-server` option, which can be used with `--output-mode static` to fully disable all server features.

```
ng build --output-mode static --no-server
```
@alan-agius4 alan-agius4 added the target: rc This PR is targeted for the next release-candidate label Oct 25, 2024
@alan-agius4 alan-agius4 requested a review from clydin October 25, 2024 06:44
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Oct 25, 2024
@alan-agius4 alan-agius4 changed the title Output mode warning changed fix(@angular/build): simplify disabling server features with --no-server via command line Oct 25, 2024
@alan-agius4 alan-agius4 modified the milestone: App triggers prerendering when prerender property Oct 25, 2024
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Oct 28, 2024
@alan-agius4 alan-agius4 merged commit d8f926f into angular:main Oct 28, 2024
33 of 34 checks passed
@alan-agius4 alan-agius4 deleted the output-mode-warning-changed branch October 28, 2024 15:08
@alan-agius4
Copy link
Collaborator Author

The changes were merged into the following branches: main, 19.0.x

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker area: @angular/build target: rc This PR is targeted for the next release-candidate
Projects
None yet
2 participants