fix(@angular/ssr): ensure wildcard RenderMode is applied when no Angular routes are defined #28718
Conversation
…lar routes are defined This fix addresses a bug where, in the absence of defined Angular routes, the RenderMode was not correctly applied based on the wildcard setting.
alan-agius4
added
the
target: rc
alan-agius4
added
the
action: review
| @@ -478,7 +478,12 @@ export async function getRoutesFromAngularRouterConfig( | |||
| } | |||
| } | |||
| } else { | |||
| routesResults.push({ route: '', renderMode: RenderMode.Prerender }); | |||
| const renderMode = serverConfigRouteTree?.match('')?.renderMode ?? RenderMode.Prerender; | |||
There was a problem hiding this comment.
@dgp1130, I'd prefer if in this case it was a hard error both the old and new API. But this would require us to generate an additional component and add route when doing ng-new.
Is this something that we'll be willing to do?
There was a problem hiding this comment.
This is the case where export const SERVER_ROUTES = [];? You think that should be a hard error?
I can see where you're coming from. This has bugged me in the past because we do the same thing for client-side routes and it means the <router-outlet> is a somewhat confusing no-op in ng new and it's not clear how to add a route, which leads to devs using component instead of loadComponent and deoptimizing their apps.
Could we generate { path: '/**', renderMode: RenderMode.Prerender } by default in SSR? Would that avoid the need for a defined route? Or do we need to add a route in the app router to get this to work?
There was a problem hiding this comment.
This is the case where export const SERVER_ROUTES = [];? You think that should be a hard error?
I was referring to Angular Router routes.
We do generate { path: '/**', renderMode: RenderMode.Prerender } already but we do not generate any route in the Angular router.
| @@ -478,7 +478,12 @@ export async function getRoutesFromAngularRouterConfig( | |||
| } | |||
| } | |||
| } else { | |||
| routesResults.push({ route: '', renderMode: RenderMode.Prerender }); | |||
| const renderMode = serverConfigRouteTree?.match('')?.renderMode ?? RenderMode.Prerender; | |||
There was a problem hiding this comment.
This is the case where export const SERVER_ROUTES = [];? You think that should be a hard error?
I can see where you're coming from. This has bugged me in the past because we do the same thing for client-side routes and it means the <router-outlet> is a somewhat confusing no-op in ng new and it's not clear how to add a route, which leads to devs using component instead of loadComponent and deoptimizing their apps.
Could we generate { path: '/**', renderMode: RenderMode.Prerender } by default in SSR? Would that avoid the need for a defined route? Or do we need to add a route in the app router to get this to work?
alan-agius4
added
action: merge
|
The changes were merged into the following branches: main, 19.0.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This fix addresses a bug where, in the absence of defined Angular routes, the RenderMode was not correctly applied based on the wildcard setting.